This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][ARM] Delete f_sels, f_seld types, use fcsel instead


On 07/08/14 12:26, Kyrill Tkachov wrote:
> Hi all,
> 
> During the great types rework this must have slipped through the cracks. 
> We had two different types to describe the fcsel (A64) and vsel (A32) 
> instructions: fcsel and f_sel[s,d].
> In the A53 pipeline description we use fcsel, so the AArch32 version was 
> presumably scheduled improperly
> This patch removes the f_sel[s,d] (I don't think we need the granularity 
> for any cores) types and gets the cmov pattern in arm.md to use the 
> fcsel like the equivalent aarch64.md pattern.
> 
> Tested arm-none-eabi on an emulator.
> 
> Ok for trunk?
> 
> 2014-08-07  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
> 
>      * config/arm/arm.md (*cmov<mode>): Set type attribute to fcsel.
>      * config/arm/types.md (f_sels, f_seld): Delete.
> 
> 

OK.  I guess if we ever do need to distinguish between 32-bit and 64-bit
selects we can add the s/d distinction back in.

R.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]