This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][testsuite] Don't run cproj-fails-with-broken-glibc.c for broken glibc


Hi Tom,

>> the test now XPASSes on Solaris, adding testsuite noise in the other
>> direction on completely innocent systems.
>
> FWIW, I would be interested in understanding the details there.

easy once you get it ;-)  The check_effective_target_* procs are
supposed to return 1 in the success case, 0 for failure.  So on
non-glibc targets like Solaris,
check_effective_target_glibc_2_11_or_earlier returns true, suggesting
the test will XFAIL while in fact it PASSes, so the XPASS.

>>  Given that we're not actually
>> testing gcc behaviour or a workaround for a glibc bug here, but just
>> alerting users to changed cproj semantics on old and newer glibc systems
>>
>> 	https://gcc.gnu.org/ml/gcc-patches/2010-04/msg01285.html
>>
>> I'd strongly suggest just removing the test and the supporting
>> effective-target keywords.
>
> Done.  Committed as attached.

Thanks.
        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]