This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PINGv3][PATCH] Fix for PR 61561


On Thu, Aug 7, 2014 at 8:36 AM, Marat Zakirov <m.zakirov@samsung.com> wrote:
> Thank you.
>
> $ svn commit
> Sending        gcc/ChangeLog
> Sending        gcc/config/arm/thumb1.md
> Sending        gcc/config/arm/thumb2.md
> Transmitting file data ...
> Committed revision 213695.
>
> P.S.
>
> Minor nit was reg. tested.

Another minor nit - please send the patch you committed to be archived
on the mailing list.

regards
Ramana

>
>
> On 08/06/2014 06:44 PM, Richard Earnshaw wrote:
>>
>> On 06/08/14 15:14, Ramana Radhakrishnan wrote:
>>>
>>>
>>> This is OK thanks.
>>>
>>>
>>> Ramana
>>>
>>
>> Hmm, minor nit.
>>
>>   (define_insn "*thumb1_movhi_insn"
>>     [(set (match_operand:HI 0 "nonimmediate_operand" "=l,l,m,*r,*h,l")
>> -       (match_operand:HI 1 "general_operand"       "l,m,l,*h,*r,I"))]
>> +       (match_operand:HI 1 "general_operand"       "lk,m,l,*h,*r,I"))]
>>
>> This would be better expressed as:
>>
>>     [(set (match_operand:HI 0 "nonimmediate_operand" "=l,l,m,l*r,*h,l")
>>          (match_operand:HI 1 "general_operand"      "l,m,l,k*h,*r,I"))]
>>
>> that is, to use the 4th alternative.  That's because the use of SP in
>> these operations does not clobber the flags.
>>
>> Similarly for the movqi pattern.
>>
>> R.
>>
>>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]