This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PINGv3][PATCH] Fix for PR 61561
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>
- Cc: Marat Zakirov <m dot zakirov at samsung dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Kyrylo Tkachov <Kyrylo dot Tkachov at arm dot com>, Christophe Lyon <christophe dot lyon at linaro dot org>, Slava Garbuzov <v dot garbuzov at samsung dot com>, Yury Gribov <y dot gribov at samsung dot com>
- Date: Wed, 06 Aug 2014 15:44:08 +0100
- Subject: Re: [PINGv3][PATCH] Fix for PR 61561
- Authentication-results: sourceware.org; auth=none
- References: <53BE8EA4 dot 7080803 at arm dot com> <53BFA9A9 dot 4090209 at samsung dot com> <CAKdteOZCDuQS4+jH1wQH4U7g5Ew1BYmtDs65xpw3c2kJ9Ek2Pw at mail dot gmail dot com> <53C64468 dot 9000506 at samsung dot com> <53C646BB dot 6020905 at arm dot com> <53C7B202 dot 3070401 at samsung dot com> <53CFB98D dot 50005 at samsung dot com> <53D8EB65 dot 7040303 at samsung dot com> <53E237CE dot 7050702 at samsung dot com> <53E23832 dot 4070707 at arm dot com>
On 06/08/14 15:14, Ramana Radhakrishnan wrote:
>
>
> This is OK thanks.
>
>
> Ramana
>
Hmm, minor nit.
(define_insn "*thumb1_movhi_insn"
[(set (match_operand:HI 0 "nonimmediate_operand" "=l,l,m,*r,*h,l")
- (match_operand:HI 1 "general_operand" "l,m,l,*h,*r,I"))]
+ (match_operand:HI 1 "general_operand" "lk,m,l,*h,*r,I"))]
This would be better expressed as:
[(set (match_operand:HI 0 "nonimmediate_operand" "=l,l,m,l*r,*h,l")
(match_operand:HI 1 "general_operand" "l,m,l,k*h,*r,I"))]
that is, to use the 4th alternative. That's because the use of SP in
these operations does not clobber the flags.
Similarly for the movqi pattern.
R.