This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Remove unnecessary and harmful fixincludes for Android
- From: Bruce Korb <bkorb at gnu dot org>
- To: Alexander Ivchenko <aivchenk at gmail dot com>
- Cc: enh <enh at google dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>, Andrew Pinski <pinskia at gmail dot com>, Andrew Hsieh <andrewhsieh at google dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 6 Aug 2014 07:07:14 -0700
- Subject: Re: Remove unnecessary and harmful fixincludes for Android
- Authentication-results: sourceware.org; auth=none
- References: <CACysShg_=6t=Pwr=L3AmAjJcB5Z5bUJA9WyxWDx2wRQ46A1=jA at mail dot gmail dot com> <CA+=Sn1nRMaODpHRHZaxRz4Qsur13_NhF7aY0SsJtEvPsftdkYA at mail dot gmail dot com> <CACysShi-izXNj=Dkn3fvc3OhDyuDu6QBDPy_MXcYOBP=eP4mJw at mail dot gmail dot com> <CAKRnqN+jDPKs69GA=qAz7pu1AxsVMYLx4Y7iJpbi25vqjvBsrA at mail dot gmail dot com> <CAJgzZooUp=TjHyHrqA+DaBPFMHKcpLyajeAKfTTEMgqtEUMY9A at mail dot gmail dot com> <CAKRnqN+mAYQ0dxUawwupSdXWULrP9cG5VbVvYmeX8v0k_yhRcg at mail dot gmail dot com> <CAJgzZorUVNHqPSf7o-0JEbhJaw+PPvZwgoVD6ud35wKYY9cFfg at mail dot gmail dot com> <CAKRnqN+-zF_T4-eSjO2S=Km183gEw9TRazcKXo3yYmEvKMq8mw at mail dot gmail dot com> <CAJgzZorQNHp6Ea_kuo9EqAxVH8jJtGmx++krKcGgjN=ah=WetQ at mail dot gmail dot com> <CACysShjuZS9f-Dt0oZM_SZ0j9v3VpEz4WS0fuYe+QvCnhcJARw at mail dot gmail dot com>
Hi,
On Wed, Aug 6, 2014 at 4:51 AM, Alexander Ivchenko <aivchenk@gmail.com> wrote:
> We still have to remove fix for compiler.h:
Correct. Thank you.
> Bruce, I think I formally have to ask for your approval again :)
I don't think so. You've selected one of the changes we wrote about,
so "With one of the two changes, the patch is approved." is sufficient,
as long as you have made either of the proposed changes.
But to be clear: Approved. (: again :)