This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Remove unnecessary and harmful fixincludes for Android
- From: enh <enh at google dot com>
- To: Bruce Korb <bkorb at gnu dot org>
- Cc: Alexander Ivchenko <aivchenk at gmail dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>, Andrew Pinski <pinskia at gmail dot com>, Andrew Hsieh <andrewhsieh at google dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 5 Aug 2014 17:31:06 -0700
- Subject: Re: Remove unnecessary and harmful fixincludes for Android
- Authentication-results: sourceware.org; auth=none
- References: <CACysShg_=6t=Pwr=L3AmAjJcB5Z5bUJA9WyxWDx2wRQ46A1=jA at mail dot gmail dot com> <CA+=Sn1nRMaODpHRHZaxRz4Qsur13_NhF7aY0SsJtEvPsftdkYA at mail dot gmail dot com> <CACysShi-izXNj=Dkn3fvc3OhDyuDu6QBDPy_MXcYOBP=eP4mJw at mail dot gmail dot com> <CAKRnqN+jDPKs69GA=qAz7pu1AxsVMYLx4Y7iJpbi25vqjvBsrA at mail dot gmail dot com> <CAJgzZooUp=TjHyHrqA+DaBPFMHKcpLyajeAKfTTEMgqtEUMY9A at mail dot gmail dot com> <CAKRnqN+mAYQ0dxUawwupSdXWULrP9cG5VbVvYmeX8v0k_yhRcg at mail dot gmail dot com> <CAJgzZorUVNHqPSf7o-0JEbhJaw+PPvZwgoVD6ud35wKYY9cFfg at mail dot gmail dot com> <CAKRnqN+-zF_T4-eSjO2S=Km183gEw9TRazcKXo3yYmEvKMq8mw at mail dot gmail dot com>
On Tue, Aug 5, 2014 at 5:26 PM, Bruce Korb <bkorb@gnu.org> wrote:
> Hi,
>
> Lines 42 & 43 are not needed for fixincludes, but it is your choice.
> With that change, you should not need to add that test to fixincludes
> because __gnuc_va_list will be found within the comment and satisfy
> the "bypass" expression.
okay, i'll reword to explicitly say that it's the reference to
__gnuc_va_list that gets us the fixincludes behavior we want (which
should also ensure that no one "cleans up" the reference to, say,
__builtin_va_list).
> That was the long way of saying:
> Looks good to me.
>
> On Tue, Aug 5, 2014 at 5:09 PM, enh <enh@google.com> wrote:
>> does https://android-review.googlesource.com/103445 look okay?
>>
>> On Tue, Aug 5, 2014 at 12:01 PM, Bruce Korb <bkorb@gnu.org> wrote:
>>> Hi,
>>>
>>> On Tue, Aug 5, 2014 at 10:36 AM, enh <enh@google.com> wrote:
>>>> you can see the current version of bionic's stdio.h here:
>>>>
>>>> https://android.googlesource.com/platform/bionic/+/master/libc/include/stdio.h
>>>>
>>>> i'm happy to add any string to the header file that makes things
>>>> easier. if you want 'x-gcc-no-fixincludes' or whatever in there, just
>>>> say :-)
>>>
>>> That would be great, but you could also add:
>>>
>>> /* this file depends on __gnuc_va_list being used for va_list */
>>>
>>> and not bother changing fixincludes at all. :) But either of those two
>>> comments added to the header would be preferable to looking for "BIONIC".
>>> Thank you!
>>>
>>> With one of the two changes, the patch is approved. Thanks!