This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 21/50] Faster for_each_rtx-like iterators

From: Jeff Law <law at redhat dot com>
To: gcc-patches at gcc dot gnu dot org, rdsandiford at googlemail dot com
Date: Tue, 05 Aug 2014 15:09:02 -0600
Subject: Re: [PATCH 21/50] Faster for_each_rtx-like iterators
Authentication-results: sourceware.org; auth=none
References: <87y4v5d77q dot fsf at googlemail dot com> <87fvhdacp8 dot fsf at googlemail dot com>

On 08/03/14 08:07, Richard Sandiford wrote:

The switch statement in the old code seemed overly cautious.  It's well
established elsewhere that the first operand of an RTX_AUTOINC is the
automodified register.  If anyone wanted to add a new code for which that
wasn't true they should (a) reconsider or (b) go through all RTX_AUTOINCs
as a precaution.


gcc/
	* emit-rtl.c: Include rtl-iter.h.
	(find_auto_inc): Turn from being a for_each_rtx callback to being
	a function that examines each subrtx itself.  Assume the first operand
	to an RTX_AUTOINC is the automodified register.
	(try_split): Update call accordingly.

OK.

It seems like we ought to document somewhere that all autoincrement RTXsincrement their first operand. If you can find a goodplace, please addthat little doc update as a pre-approved patch.


jeff

References:
- [PATCH 0/50] Faster for_each_rtx-like iterators
  - From: Richard Sandiford
- [PATCH 21/50] Faster for_each_rtx-like iterators
  - From: Richard Sandiford

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]