This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Remove unnecessary and harmful fixincludes for Android
- From: Bruce Korb <bkorb at gnu dot org>
- To: enh <enh at google dot com>
- Cc: Alexander Ivchenko <aivchenk at gmail dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>, Andrew Pinski <pinskia at gmail dot com>, Andrew Hsieh <andrewhsieh at google dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 5 Aug 2014 12:01:28 -0700
- Subject: Re: Remove unnecessary and harmful fixincludes for Android
- Authentication-results: sourceware.org; auth=none
- References: <CACysShg_=6t=Pwr=L3AmAjJcB5Z5bUJA9WyxWDx2wRQ46A1=jA at mail dot gmail dot com> <CA+=Sn1nRMaODpHRHZaxRz4Qsur13_NhF7aY0SsJtEvPsftdkYA at mail dot gmail dot com> <CACysShi-izXNj=Dkn3fvc3OhDyuDu6QBDPy_MXcYOBP=eP4mJw at mail dot gmail dot com> <CAKRnqN+jDPKs69GA=qAz7pu1AxsVMYLx4Y7iJpbi25vqjvBsrA at mail dot gmail dot com> <CAJgzZooUp=TjHyHrqA+DaBPFMHKcpLyajeAKfTTEMgqtEUMY9A at mail dot gmail dot com>
Hi,
On Tue, Aug 5, 2014 at 10:36 AM, enh <enh@google.com> wrote:
> you can see the current version of bionic's stdio.h here:
>
> https://android.googlesource.com/platform/bionic/+/master/libc/include/stdio.h
>
> i'm happy to add any string to the header file that makes things
> easier. if you want 'x-gcc-no-fixincludes' or whatever in there, just
> say :-)
That would be great, but you could also add:
/* this file depends on __gnuc_va_list being used for va_list */
and not bother changing fixincludes at all. :) But either of those two
comments added to the header would be preferable to looking for "BIONIC".
Thank you!
With one of the two changes, the patch is approved. Thanks!