This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][testsuite] Don't run cproj-fails-with-broken-glibc.c for broken glibc
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: Tom de Vries <Tom_deVries at mentor dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 05 Aug 2014 13:51:15 +0200
- Subject: Re: [PATCH][testsuite] Don't run cproj-fails-with-broken-glibc.c for broken glibc
- Authentication-results: sourceware.org; auth=none
- References: <53DA9714 dot 5070707 at mentor dot com> <yddha1wlcpo dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <53DD1143 dot 2030001 at mentor dot com> <DF4ACEE4-2A6A-4159-9D2E-D587B8EE6DAB at comcast dot net>
Hi Mike,
>> Or do we go with the removal suggestion of Mike?
>
> Iâll let others weigh in. Iâm fine either way. Original author likely
> prefers the xfail, so Iâm fine with the above.
the test now XPASSes on Solaris, adding testsuite noise in the other
direction on completely innocent systems. Given that we're not actually
testing gcc behaviour or a workaround for a glibc bug here, but just
alerting users to changed cproj semantics on old and newer glibc systems
https://gcc.gnu.org/ml/gcc-patches/2010-04/msg01285.html
I'd strongly suggest just removing the test and the supporting
effective-target keywords.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University