This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] FAIL: gcc.dg/torture/ftrapv-1.c -O0 (test for excess errors) on bare-metal targets


On Tue, Aug 5, 2014 at 11:47 AM, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
> Hi all,
>
> The recently added -ftrapv test FAILS on bare metal targets because it
> requires the usage of fork.
> It does have a dg-require-fork guard but apparently that function takes an
> unused argument and if you don't give it that, DejaGNU will happily ignore
> the directive and not bother checking for the presence of fork :S
>
> The other places where I see dg-require-fork being used is in the libstdc++
> testsuite. Perhaps it's worth just removing the argument from the definition
> of dg-require-fork in target-supports-dg.exp, but there is a whole host of
> functions that take an argument and then don't use it (dg-require-mkfifo is
> one, for example) so it seems like it would be an out-of-place change unless
> we do a big sweep across the testsuite library to clean that stuff up. This
> patch just fixes the dg-requires-fork invocation in
> gcc.dg/torture/ftrapv-1.c.
>
> Richard (and testsuite maintainers), is this ok? or would you prefer to
> remove the unused arguments for the dg-requires-* functions in
> testsuite/lib/ ?
>
> With this patch the test now appears as UNSUPPORTED on bare metal aarch64
> and arm targets (that I've tested).

Eh, I thought I fixed that already... (must have failed to commit).

OK.

Thanks,
Richard.

> Thanks,
> Kyrill
>
> 2014-08-05  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>
>     * gcc.dg/torture/ftrapv-1.c: Correct usage of dg-require-fork.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]