This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][Ping v5] Add patch for debugging compiler ICEs


Thanks Jeff and Jakub, I've reposted ICE debugging patch into gcc-patches mailing list (https://gcc.gnu.org/ml/gcc-patches/2014-08/msg00285.html).

-Maxim
On 08/01/2014 11:29 PM, Jeff Law wrote:
On 08/01/14 02:00, Jakub Jelinek wrote:
On Thu, Jul 24, 2014 at 04:39:28PM +0400, Maxim Ostapenko wrote:
Ping.

Don't want to review a patch I wrote partially, so just a few comments:
1) IMHO it should be configure time selectable (not sure about the default,
but for non-release branches IMHO it should default to off, for release
branches I don't know).  The point is that while it is useful for
people to report gcc bugs in production compilers, it is not useful for
gcc developers on their boxes, having ICEs take 3 times as long is not
desirable for people who deal with those all the time
We definitely want the ability to select. Waiting on an ICE to trigger 3 times would be painful for the developers. So I'd think that enabled for the release branches and disabled for the trunk would be the right default.


2) recently a bug has been reported that some ICEs which print RTL
to stderr are considered non-reproduceable, because the addresses e.g.
in call_insn fndecl change through address space randomization. For the
retries the driver should supposedly append -fdump-noaddr.
Right.  I think we discussed this at Cauldron.

I think it's conceptually ok with those two changes, then it's just reviewing the details.

If you or Maxim could make those changes and repost, I'll cover the review.

jeff



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]