This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] convert many pointer_map to hash_map


On 02 Aug 2014, at 17:58, Trevor Saunders <tsaunders@mozilla.com> wrote:

> On Sat, Aug 02, 2014 at 05:38:42PM +0200, Oleg Endo wrote:
>> On Sat, 2014-08-02 at 07:34 -0400, Trevor Saunders wrote:
>>> On Fri, Aug 01, 2014 at 12:52:08PM +0200, Richard Biener wrote:
>>>> On Fri, Aug 1, 2014 at 12:34 PM,  <tsaunders@mozilla.com> wrote:
>>>>> From: Trevor Saunders <tsaunders@mozilla.com>
>>>>> 
>>>>> Hi,
>>>>> 
>>>>> This patch replaces a bunch of usage of pointer_map with hash_map.  It also
>>>>> adds an overload to hash_map::traverse that allows modifying the value, and a
>>>>> remove method.
>>>>> 
>>>>> bootstrapped + regtested on x86_64-unknown-linux-gnu, ok?
>>>> 
>>>> Ok.
>>> 
>>> committed as r213517 thanks for the review.
>>> 
>>> Trev
>>> 
>> 
>> Either r213517 or r213516 is causing the following on my sh-elf setup
>> (i686 host) when doing 'make all':
> 
> I'd guess that its r213517, and for  at least one of the hash maps we're
> leaking what the entries point at.  Can you try compiling that file
> under valgrind? if not I can try in a couple hours.

I think you'll be faster than me.

Cheers,
Oleg

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]