This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] convert many pointer_map to hash_map
- From: Trevor Saunders <tsaunders at mozilla dot com>
- To: Oleg Endo <oleg dot endo at t-online dot de>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 2 Aug 2014 11:58:16 -0400
- Subject: Re: [PATCH] convert many pointer_map to hash_map
- Authentication-results: sourceware.org; auth=none
- References: <1406889295-22653-1-git-send-email-tsaunders at mozilla dot com> <CAFiYyc0NOnuqzhHe=hNWpqzfKVawyj2pQKQbMYS5Oy3cfuaNEw at mail dot gmail dot com> <20140802113410 dot GB26489 at tsaunders-iceball dot corp dot tor1 dot mozilla dot com> <1406993922 dot 14383 dot 118 dot camel at yam-132-YW-E178-FTW>
On Sat, Aug 02, 2014 at 05:38:42PM +0200, Oleg Endo wrote:
> On Sat, 2014-08-02 at 07:34 -0400, Trevor Saunders wrote:
> > On Fri, Aug 01, 2014 at 12:52:08PM +0200, Richard Biener wrote:
> > > On Fri, Aug 1, 2014 at 12:34 PM, <tsaunders@mozilla.com> wrote:
> > > > From: Trevor Saunders <tsaunders@mozilla.com>
> > > >
> > > > Hi,
> > > >
> > > > This patch replaces a bunch of usage of pointer_map with hash_map. It also
> > > > adds an overload to hash_map::traverse that allows modifying the value, and a
> > > > remove method.
> > > >
> > > > bootstrapped + regtested on x86_64-unknown-linux-gnu, ok?
> > >
> > > Ok.
> >
> > committed as r213517 thanks for the review.
> >
> > Trev
> >
>
> Either r213517 or r213516 is causing the following on my sh-elf setup
> (i686 host) when doing 'make all':
I'd guess that its r213517, and for at least one of the hash maps we're
leaking what the entries point at. Can you try compiling that file
under valgrind? if not I can try in a couple hours.
Trev
>
> libtool: compile: /home/user/code/gcc/gcc-trunk-build-sh-elf/./gcc/xgcc
> -shared-libgcc -B/home/user/code/gcc/gcc-trunk-build-sh-elf/./gcc
> -nostdinc++ -L/home/user/code/gcc/gcc-trunk-build-sh-elf/sh-elf/libstdc
> ++-v3/src -L/home/user/code/gcc/gcc-trunk-build-sh-elf/sh-elf/libstdc
> ++-v3/src/.libs
> -L/home/user/code/gcc/gcc-trunk-build-sh-elf/sh-elf/libstdc++-v3/libsupc
> ++/.libs -B/usr/local/sh-elf/bin/ -B/usr/local/sh-elf/lib/
> -isystem /usr/local/sh-elf/include
> -isystem /usr/local/sh-elf/sys-include
> -I/home/user/code/gcc/gcc-trunk/libstdc++-v3/../libgcc
> -I/home/user/code/gcc/gcc-trunk-build-sh-elf/sh-elf/libstdc
> ++-v3/include/sh-elf
> -I/home/user/code/gcc/gcc-trunk-build-sh-elf/sh-elf/libstdc++-v3/include
> -I/home/user/code/gcc/gcc-trunk/libstdc++-v3/libsupc++ -std=gnu++11
> -fno-implicit-templates -Wall -Wextra -Wwrite-strings -Wcast-qual -Wabi
> -fdiagnostics-show-location=once -ffunction-sections -fdata-sections
> -frandom-seed=fstream-inst.lo -g -O2 -c ../../../../../gcc-trunk/libstdc
> ++-v3/src/c++11/fstream-inst.cc -o fstream-inst.o
>
> cc1plus: out of memory allocating 2129023400 bytes after a total of
> 1589248 bytes
> make[5]: *** [fstream-inst.lo] Error 1
> make[5]: Leaving directory
> `/home/user/code/gcc/gcc-trunk-build-sh-elf/sh-elf/libstdc++-v3/src/c
> ++11'
>
> Cheers,
> Oleg
>