This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH, i386] Handle extended family cpuid info for AMD


Uros!

> I would like to have a check for a family at the beginning, something like:

>      if (name == signature_NSC_ebx)
>    processor = PROCESSOR_GEODE;
>      else if (family == 22)
>    {
>      if (has_movbe)

I get your idea of having the family checked first and then differentiating with cpuid info later.
But, this case is getting interesting because, BTVER1 and BTVER2 are two variants but don't really have same family numbers.
BTVER1 is family 14h and BTVER2 is family 16h. I don't see near term plans for any additional cpus to either 14h or 16h.
Given that fact, this particular check is applicable only for BTVER2.
In that case, having 

      else if (family == 22)
        if (has_movbe)
           processor = PROCESSOR_BTVER2;

looks odd. 

Regards
Ganesh

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]