This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH 5/5] add libcc1
- From: Trevor Saunders <tsaunders at mozilla dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, Jeff Law <law at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 31 Jul 2014 22:16:21 -0400
- Subject: Re: [PATCH 5/5] add libcc1
- Authentication-results: sourceware.org; auth=none
- References: <1400254001-12038-1-git-send-email-tromey at redhat dot com> <87oayx4l0x dot fsf at fleche dot redhat dot com> <87bntobp1f dot fsf at fleche dot redhat dot com> <53D9CA7B dot 3040709 at redhat dot com> <CAFiYyc0VpAG6s+JbQL-GpO2woSznGWzezD6wHTQoO9ZXH2QCEw at mail dot gmail dot com> <87bns5s5op dot fsf at fleche dot redhat dot com> <20140731194304 dot GA1119 at tsaunders-iceball dot corp dot tor1 dot mozilla dot com> <874mxxs3vy dot fsf at fleche dot redhat dot com>
On Thu, Jul 31, 2014 at 01:51:45PM -0600, Tom Tromey wrote:
> >>>>> "Trevor" == Trevor Saunders <email@example.com> writes:
> Trevor> the plugin part seems fine, but I do find my self wondering if there's a
> Trevor> better way of doing the hooks into C, if they can be more genrally
> Trevor> useful.
> There's just one now, the binding oracle.
ah, that seems reasonable enough.
> (There used to be two but we reimplemented the second one by overriding
> a langhook from the plugin.)
hm, I think langhooks should eventually become an interface with virtual
functions to help seperate front ends, and that may be interesting with
plugins that over ride lang hooks from the front end, but we need to
cross that bridge anyway I guess.
> The binding oracle could perhaps be redone as an ordinary plugin event.
> It didn't seem that worthwhile to me, but if someone else has a use, it
> seems doable.
> Trevor> out of process seems very reasonable, but I do hope we'll fix the
> Trevor> crashes since there's any number of other uses for cc1 as a library.
> The ones I recall were all things like the plugin making a tree
> incorrectly. This could still be an issue but it is one unlikely to be
> hit in ordinary uses of the compiler. I agree any such things are bugs
Then that seems fine.
So as far as I'm concerned please lets go forward with this and clean up
later as needed.