This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC, PATCH 3/n] IPA C++ refactoring
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Martin Liška <mliska at suse dot cz>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, hubicka at ucw dot cz
- Date: Thu, 31 Jul 2014 23:30:46 +0200
- Subject: Re: [RFC, PATCH 3/n] IPA C++ refactoring
- Authentication-results: sourceware.org; auth=none
- References: <53DAB28F dot 9030803 at suse dot cz>
> Hello,
> in the following patch, I would like to introduce a new template class (indexed_set) that can replace many cgraph_node_set and varpool_node_set related functions.
>
> Bootstrapped on x86_64-pc-linux-gnu, no regression observed.
>
> Thank you,
> Martin
> 2014-07-31 Martin Liska <mliska@suse.cz>
>
> * cgraph.h (cgraph_node_set, varpool_node_set): Removed structs and all
> related functions that manipulated these data structures.
> (cgraph_new_nodes): vec replaces cgraph_node_set.
> * cgraphunit.c (cgraph_new_nodes): Likewise.
> (cgraph_process_new_functions): Usage of newly added indexed_set class.
> (cgraph_node::add_new_function): Likewise.
> * indexed-set.h: New data structure.
> * ipa-inline-transform.c (can_remove_node_now_p_1): Usage of newly
> added indexed_set class.
> * ipa-utils.c: Implementations of legacy data structures removed.
> * tree-emutls.c (tls_vars): indexed_set replaces varpool_node_set.
> (emutls_index): New functions are used.
> (ipa_lower_emutls): Likewise.
As a cgraph maintainer I am very happy to see cgraph_node_set and varpool_node_set
to go. I would however preffer someone to approve the indexed-set.h implementation.
Honza