This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, ARM] Fix PR61948 (ICE with DImode shift by 1 bit)


On 30 July 2014 11:48, Richard Earnshaw <rearnsha@arm.com> wrote:
>> gcc/ChangeLog:
>> 2014-07-29  Charles Baylis  <charles.baylis@linaro.org>
>>
>>     PR target/61948
>>     * config/arm/neon.md (ashldi3_neon): Don't emit arm_ashldi3_1bit unless
>>     constraints are satisfied.
>>     (<shift>di3_neon): Likewise.
>>
>
> This is OK, but...
>>
>> gcc/testsuite/ChangeLog:
>> 2014-07-29  Charles Baylis  <charles.baylis@linaro.org>
>>
>>     PR target/61948
>>     * gcc.target/arm/pr61948.c: New test case.
>
> I think this should be using something like:
>
> /* { dg-do compile } */
> /* { dg-require-effective-target arm_neon_ok } */
> /* { dg-require-effective-target arm_thumb2_ok } */
> /* { dg-options "-O2 -mthumb" } */
> /* { dg-add-options arm_neon } */
>
> rather than explicitly adding -mfpu=neon.

I made that change, and committed to trunk as r213376.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]