This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH 1/6] RTL & dwarf2out changes
- From: Cary Coutant <ccoutant at google dot com>
- To: Andi Kleen <andi at firstfloor dot org>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Andi Kleen <ak at linux dot intel dot com>
- Date: Mon, 28 Jul 2014 11:48:58 -0700
- Subject: Re: [PATCH 1/6] RTL & dwarf2out changes
- Authentication-results: sourceware.org; auth=none
- References: <1406489825-9561-1-git-send-email-andi at firstfloor dot org> <1406489825-9561-2-git-send-email-andi at firstfloor dot org>
> + /* ??? MD5 of another hash doesn't make a lot of sense... */
> + hash = hstate.end();
> CHECKSUM (hash);
 I don't see why you think that. Maybe it'd be nicer
if we could use hash_loc_operands() to feed its input directly into
the MD5 checksum, but I think in this case it's perfectly fine to use
the hash instead, in order to avoid reimplementing a rather
substantial function that already exists.
Maybe we could make hash_loc_operands() a template that can be used as
part of either inchash or MD5?
In the case of loc_checksum(), we're tied to MD5 by the DWARF
standard. Otherwise, we could just rewrite it to use inchash