This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] allow running mklog as a filter


On Mon, Jul 28, 2014 at 06:29:22PM +0400, Yury Gribov wrote:
> On 07/28/2014 03:01 PM, Trevor Saunders wrote:
> >>Yeah. Do you have some particular complaints btw?
> >
> >I haven't actually used it in a while, but istr there's an issue where
> >if you change the prototype of a function mklog makes an entry for the
> >previous function.
> 
> I think this is because mklog relies on markers generated by diff -p
> (like @@ -96,20 +108,22 @@ bitmap_descriptor (const char *file, int line,
> const char *function)).
> Diff will indeed report old name instead of the new one.

that was my guess as well, I imagine it can be fixed with enough work,
but given my limited use of mklog so far I haven't tried to fix it.

> >Automatically inserting likewise where it would be appropriate would be
> >nice, but fairly hard I suspect.
> 
> This depends on the actual use-case. For tests and deleted files this
> should be relatively straightforward but probably not very useful.

yeah, I forget exactly what mklog does now for created / removed files,
but making it take care of those on its own would be nice.  You might
also be able to deal with function renaming fairly well with some
effort.

Trev

> 
> -Y


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]