This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Rewrite edge flag checking statements to prevent problem with new flags
- From: Jeff Law <law at redhat dot com>
- To: Yi Yang <ahyangyi at google dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Cc: Dehao Chen <dehao at google dot com>
- Date: Tue, 22 Jul 2014 21:16:58 -0600
- Subject: Re: [PATCH] Rewrite edge flag checking statements to prevent problem with new flags
- Authentication-results: sourceware.org; auth=none
- References: <CADvRseY9CxALR03WwnKiTaFZBLx0g4SQ1P2QSptAN98a=H8u9g at mail dot gmail dot com>
On 07/16/14 12:41, Yi Yang wrote:
One could easily argue that 'fragile' in this context is what we
actually want. Ie, if someone introduces a new edge flag, they ought to
be looking at how that impacts verification.
There are a few if statements in cfgrtl.c that are very fragile in the
sense that introducing an irrelevant edge flag breaks things.
This patch rewrites them to avoid such breakage.
2014-07-16 Yi Yang <email@example.com>
* cfgrtl.c (rtl_verify_edges, purge_dead_edges): Rewrite certain
I strongly prefer to have developers explicitly handle any new edge
flags in the verification code. If they are truly irrelevant for
verification, it's easy enough to filter them out in the appropriate