This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] gcc/toplev.c: Avoid to close 'asm_out_file' when it is 'stdout'

From: Jeff Law <law at redhat dot com>
To: Chen Gang <gang dot chen dot 5i5j at gmail dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>, rth at redhat dot com, gcc-patches at gcc dot gnu dot org
Date: Tue, 22 Jul 2014 21:44:54 -0600
Subject: Re: [PATCH] gcc/toplev.c: Avoid to close 'asm_out_file' when it is 'stdout'
Authentication-results: sourceware.org; auth=none
References: <53CD3617 dot 2000503 at gmail dot com>

On 07/21/14 09:47, Chen Gang wrote:

'asm_out_file' may be 'stdout', so need check this case before close it.
Or 'stdout' may be closed -- since need not open 'stdout', either need
not close it.

ChangLog:

   * topleve.c (finalize): Avoid to close 'asm_out_file' when it is
   'stdout'.

What exactly is the problem with closing stdout at this point? Ingeneral, you need to state the problem you're trying to fix with your patch.



Jeff

Follow-Ups:
- Re: [PATCH] gcc/toplev.c: Avoid to close 'asm_out_file' when it is 'stdout'
  - From: Chen Gang

References:
- [PATCH] gcc/toplev.c: Avoid to close 'asm_out_file' when it is 'stdout'
  - From: Chen Gang

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]