This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH, i386, PR61827] Fix fuse-caller-save-xmm.c test-case
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Tom de Vries <Tom_deVries at mentor dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Dominique Dhumieres <dominiq at lps dot ens dot fr>
- Date: Mon, 21 Jul 2014 12:40:08 +0200
- Subject: Re: [PATCH, i386, PR61827] Fix fuse-caller-save-xmm.c test-case
- Authentication-results: sourceware.org; auth=none
- References: <53CB9931 dot 6030800 at mentor dot com> <CAFULd4a-KsW1AuULGkp4izYCkFxpvR2CiXP03T7cV1p4WhMfiQ at mail dot gmail dot com> <53CCECA7 dot 9070607 at mentor dot com>
On Mon, Jul 21, 2014 at 12:34 PM, Tom de Vries <Tom_deVries@mentor.com> wrote:
> Dominique noticed that the .LC0 check failed on darwin, since the label LC0
> is used. This follow-up patch fixes that (and I see now you already Ok-ed
> this change).
> Furthermore, I've realized from the comments in the PR that for
> solaris/sun-as and darwin no cfi directives are generated. There are two
> other i386 fuse-caller-save tests which test cfi directives. The reason
> these tests aren't failing for solaris/sun-as and darwin like the
> fuse-caller-save-xmm test did, is because they test for the absence of
> specific cfi directives, which will always pass if no cfi directives are
> generated. So I've removed the cfi directive checks (and removed superfluous
> mains) and added tests on instructions.
> Tested with -m32 and -m64.
> OK for trunk?
This is OK.