Re: [PING][PATCH] Fix for PR 61561

[Kyrill Tkachov <kyrylo dot tkachov at arm dot com>]

On 16/07/14 10:22, Marat Zakirov wrote:
> Christophe,
>
> Please look at a new patch.  Draft tests are OK.
> I'll ask your commit approval when full regression (ARM/thumb1/thumb2)
> tests are done.
Hi Marat,

I was about to propose the thumb2.md hunk myself, but I'll defer to the 
arm maintainers to comment on the other parts.

Also, in the ChangeLog it is helpful to specify which patterns are being 
affected, so in your case it would be something like:

	* config/arm/thumb1.md (*thumb1_movhi_insn): Handle stack pointer.
	(*thumb1_movqi_insn): Likewise.
	* config/arm/thumb2.md (*thumb2_movhi_insn): Ditto.


Kyrill

> Thank for your attention.
>
> --Marat
>
> On 07/11/2014 11:19 PM, Christophe Lyon wrote:
> > The new testcase causes an ICE when the compile is configured
> > --with-thumb or when forcing -mthumb.
> >
> > Christophe.
> >
> >
> > On 11 July 2014 11:08, Marat Zakirov <m.zakirov@samsung.com> wrote:
> > > Thank to you all.
> > >
> > > Committed revision 212450.
> > >
> > > --Marat
> > >
> > >
> > > -------- Original Message --------
> > > Subject:        Re: [PING][PATCH] Fix for PR 61561
> > > Date:   Thu, 10 Jul 2014 14:01:24 +0100
> > > From:   Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
> > > To:     Marat Zakirov <m.zakirov@samsung.com>, "gcc-patches@gcc.gnu.org"
> > > <gcc-patches@gcc.gnu.org>
> > > CC:     Richard Earnshaw <Richard.Earnshaw@arm.com>, Kyrylo Tkachov
> > > <Kyrylo.Tkachov@arm.com>, Slava Garbuzov <v.garbuzov@samsung.com>, Yuri
> > > Gribov <tetra2005@gmail.com>, "marat61@gmail.com" <marat61@gmail.com>
> > >
> > >
> > >
> > >
> > >
> > > On 30/06/14 16:21, Marat Zakirov wrote:
> > > > Thank for your attention.
> > > This is OK for trunk - Sorry about the delayed response.
> > >
> > > Ramana
> > >
> > > > Marat.