Re: [patch,gomp-4_0-branch] misc reduction clause bug fixes

[Thomas Schwinge <thomas at codesourcery dot com>]

Hi Cesar!

On Thu, 10 Jul 2014 11:43:11 -0700, Cesar Philippidis <cesar@codesourcery.com> wrote:
> This patch addresses two bugs openacc reduction clause bugs.

Thanks!  OK; one question/suggestion, though:

> --- a/gcc/omp-low.c
> +++ b/gcc/omp-low.c
> @@ -9679,11 +9679,23 @@ process_reduction_data (gimple_seq *body, gimple_seq *in_stmt_seqp,
>    gcc_assert (is_gimple_omp_oacc_specifically (ctx->stmt));
>  
>    gimple_stmt_iterator gsi;
> +  gimple_seq inner;
> +  gimple stmt;
> +
> +  /* A collapse clause may have inserted a new bind block.  */
> +  stmt = gimple_seq_first (*body);
> +  if (stmt && gimple_code (stmt) == GIMPLE_BIND)
> +    {
> +      inner = gimple_bind_body (gimple_seq_first (*body));
> +      body = &inner;
> +    }
>  
>    for (gsi = gsi_start (*body); !gsi_end_p (gsi); gsi_next (&gsi))
>      {
>        gimple stmt = gsi_stmt (gsi);

Can get rid of this shadow variable stmt?


GrÃÃe,
 Thomas

Attachment: pgpw_vMehh0zr.pgp
Description: PGP signature