This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Fix ELFv2 homogeneous float aggregate ABI bug
- From: Jakub Jelinek <jakub at redhat dot com>
- To: David Edelsohn <dje dot gcc at gmail dot com>
- Cc: Ulrich Weigand <uweigand at de dot ibm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 10 Jul 2014 12:53:08 +0200
- Subject: Re: [PATCH, rs6000] Fix ELFv2 homogeneous float aggregate ABI bug
- Authentication-results: sourceware.org; auth=none
- References: <201407091602 dot s69G2QOm014547 at d06av02 dot portsmouth dot uk dot ibm dot com> <CAGWvny=F-=JOsC7PzKu9rdQH3RfDYsbpYbUOdSMvof9aLW6rEQ at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Jul 09, 2014 at 02:19:36PM -0400, David Edelsohn wrote:
> > This is an ABI change for the affected corner cases of the ELFv2
> > ABI. However, those cases should be extremely rare; the full
> > compat.exe and struct-layout-1.exp ABI compatibility test suite
> > passed, with the exception of two tests specifically intended
> > to test multiple homogeneous float aggregates.
> >
> > Tested on powerpc64le-linux.
> >
> > OK for mainline?
> > [ The patch should then also go into the 4.8 and 4.9 branches for
> > consistency. ]
>
> Okay everywhere.
IMHO it should only go to the trunk, same as
https://gcc.gnu.org/ml/gcc-patches/2014-07/msg00540.html (see also related
PRs, has been discussed on IRC too).
If it is a corner case, the better, fewer people will be affected when
transitioning from 4.9.x to 5.0 (or 4.10?). But 4.9.0 is for a few months
in the wild already, I don't think ABI changes are something people would
like to see between 4.9.0 and 4.9.1 or any other patchlevel revision,
most people aren't prepared to rebuild the world just because they have
upgraded to a newer compiler snapshot or new patchlevel version.
Jakub