This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [BUILDROBOT] xtensa fallout (was: Turn DECL_SECTION_NAME into string)

From: Jan-Benedict Glaw <jbglaw at lug-owl dot de>
To: "augustine dot sterling at gmail dot com" <augustine dot sterling at gmail dot com>
Cc: Jan Hubicka <hubicka at ucw dot cz>, Jan Hubicka <jh at suse dot cz>, gcc-patches at gcc dot gnu dot org
Date: Fri, 4 Jul 2014 23:11:30 +0200
Subject: Re: [BUILDROBOT] xtensa fallout (was: Turn DECL_SECTION_NAME into string)
Authentication-results: sourceware.org; auth=none
References: <20140612043325 dot GA6864 at kam dot mff dot cuni dot cz> <20140625011651 dot GN31494 at lug-owl dot de> <20140625052053 dot GD30367 at kam dot mff dot cuni dot cz> <CAGSvup93+h_yCFLJ-xqnh-Xoce3Sax86jOx5sPHBb2jmxsC1Og at mail dot gmail dot com>

On Wed, 2014-06-25 08:55:57 -0700, augustine.sterling@gmail.com <augustine.sterling@gmail.com> wrote:
> On Tue, Jun 24, 2014 at 10:20 PM, Jan Hubicka <hubicka@ucw.cz> wrote:
> > > This is the xtensa fallout, see http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=272418
> > >
> > > g++ -c   -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I/home/jbglaw/repos/gcc/gcc -I/home/jbglaw/repos/gcc/gcc/. -I/home/jbglaw/repos/gcc/gcc/../include -I/home/jbglaw/repos/gcc/gcc/../libcpp/include  -I/home/jbglaw/repos/gcc/gcc/../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libbacktrace    -o insn-preds.o -MT insn-preds.o -MMD -MP -MF ./.deps/insn-preds.TPo insn-preds.c
> > > /home/jbglaw/repos/gcc/gcc/config/xtensa/predicates.md: In function âint call_insn_operand_1(rtx, machine_mode)â:
> > > /home/jbglaw/repos/gcc/gcc/config/xtensa/predicates.md:113:57: error: cannot convert âconst char*â to âtreeâ in assignment
> > > /home/jbglaw/repos/gcc/gcc/config/xtensa/predicates.md:119:46: error: cannot convert âconst char*â to âtreeâ in assignment
> > > make[1]: *** [insn-preds.o] Error 1
> > Should be fixed by this (and I see in my prevoius mail I wanted TREE_STRING_POINTER)
> 
> [resend due to gmail's stupid html-by-default]
> 
> This patch looks correct to me, but I haven't watched quite enough of
> the underlying change to know that replacing the strcmp with pointer
> equality is really the right thing.
> 
> If it is, approved for Xtensa.

*ping*

As Jan wrote it, I *guess* it probably is (haven't checked.)

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of:               http://www.eyrie.org/~eagle/faqs/questions.html
the second  :

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [BUILDROBOT] xtensa fallout (was: Turn DECL_SECTION_NAME into string)
  - From: augustine dot sterling at gmail dot com

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]