This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [AArch64,PATCH] Refactor acquire/release determination into output template


On 4 June 2014 01:07, Jones, Joel <Joel.Jones@caviumnetworks.com> wrote:
> There is duplicate code for determining whether a load or store
> instruction needs acquire or release semantics.  This patch removes the duplicated code and uses a modifying operator to output a/l instead.  Since the testsuite already contains tests for the atomic functions, no new testcases are needed.
>
> OK? Built and tested for aarch64-elf using Cavium's internal simulator with no regressions.
>
> Thanks,
> Joel Jones


There are a limited number of single character output modifiers. I'd
rather not consume the available character space if it isn't
necessary, therefore I prefer not to restructure the code in the
manner proposed by this patch.

Cheers
/Marcus


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]