This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Don't run guality.exp tests with LTO_TORTURE_OPTIONS.


While writing new guality.exp tests I noticed they often just fail
when ran with -flto, even though they PASS in all other cases. When
I asked on irc about this I was told that LTO was known to not play
well with DWARF debuginfo anyway. If that is the case, it seems better
to disable -flto for guality.exp for now since it just adds noise
(and unfortunately guality.exp already has lots of FAILs). The attached
patch does this. It changes the make check-c RUNTESTFLAGS=guality.exp
results (against gdb git master) from:

# of expected passes            3121
# of unexpected failures        180
# of unexpected successes       33
# of expected failures          15
# of unsupported tests          78


# of expected passes            2389
# of unexpected failures        110
# of unexpected successes       26
# of expected failures          10
# of unsupported tests          54

That looks like an improvement to me, even though the number of FAILs
is still a bit high. Does this look a good thing to apply? Or are people
actively working on reducing the number of LTO guality.exp failures and
can we expect them to turn into PASSes soon anyway?




	* gcc.dg/guality/guality.exp: Remove LTO_TORTURE_OPTIONS from
	set-torture-options. Only use DG_TORTURE_OPTIONS.
 gcc/testsuite/ChangeLog                  |    5 +++++
 gcc/testsuite/gcc.dg/guality/guality.exp |    6 ++++++
 2 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index b364f40..421e006 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2014-07-02  Mark Wielaard  <>
+	* gcc.dg/guality/guality.exp: Remove LTO_TORTURE_OPTIONS from
+	set-torture-options. Only use DG_TORTURE_OPTIONS.
 2014-07-02  Uros Bizjak  <>
 	* gfortran.dg/ieee/ieee_1.F90 (dg-additional-options): Remove -O0.
diff --git a/gcc/testsuite/gcc.dg/guality/guality.exp b/gcc/testsuite/gcc.dg/guality/guality.exp
index 5e714dd..7991661 100644
--- a/gcc/testsuite/gcc.dg/guality/guality.exp
+++ b/gcc/testsuite/gcc.dg/guality/guality.exp
@@ -47,6 +47,12 @@ if {[check_guality "
     return 0;
 "]} {
+  # Override default torture-options which include LTO_TORTURE_OPTIONS
+  # Currently LTO and the guality tests that depend on debuginfo don't mix.
+  torture-init
+  set-torture-options $DG_TORTURE_OPTIONS
   gcc-dg-runtest [lsort [glob $srcdir/$subdir/*.c]] ""
   gcc-dg-runtest [lsort [glob $srcdir/c-c++-common/guality/*.c]] "-Wc++-compat"

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]