This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, 3/10] skip swapping operands used in ccmp


On 06/25/14 08:44, Richard Earnshaw wrote:
On 23/06/14 07:58, Zhenqiang Chen wrote:
Hi,

Swapping operands in a ccmp will lead to illegal instructions. So the
patch disables it in simplify_while_replacing.

The patch is separated from
https://gcc.gnu.org/ml/gcc-patches/2014-02/msg01407.html.

To make it clean. The patch adds two files: ccmp.{c,h} to hold all new
ccmp related functions.

OK for trunk?

Thanks!
-Zhenqiang

ChangeLog:
2014-06-23  Zhenqiang Chen  <zhenqiang.chen@linaro.org>

         * Makefile.in: Add ccmp.o
         * ccmp.c: New file.

Do we really need a new file for one 10-line function?  Seems like
overkill.  I think it would be better to just drop this function into
recog.c.
Right. And if we did want a new file, clearly the #includes need to be trimmed :-)


Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]