This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/3] add hash_map class

From: Martin LiÅka <mliska at suse dot cz>
To: Richard Biener <richard dot guenther at gmail dot com>, Trevor Saunders <tsaunders at mozilla dot com>, Jan Hubicka <hubicka at ucw dot cz>
Cc: gcc-patches at gcc dot gnu dot org
Date: Wed, 25 Jun 2014 16:14:18 +0200
Subject: Re: [PATCH 3/3] add hash_map class
Authentication-results: sourceware.org; auth=none
References: <1403261538-884-1-git-send-email-tsaunders at mozilla dot com> <1403261538-884-3-git-send-email-tsaunders at mozilla dot com> <53A96F41 dot 4080301 at suse dot cz> <20140624182349 dot GB5997 at atrey dot karlin dot mff dot cuni dot cz> <20140624191634 dot GB24913 at tsaunders-iceball dot corp dot tor1 dot mozilla dot com> <65c89982-e9b3-403b-91d6-09ab29d6aef3 at email dot android dot com>


On 06/24/2014 09:31 PM, Richard Biener wrote:

On June 24, 2014 9:16:34 PM CEST, Trevor Saunders <tsaunders@mozilla.com> wrote:

On Tue, Jun 24, 2014 at 08:23:49PM +0200, Jan Hubicka wrote:

On 06/20/2014 12:52 PM, tsaunders@mozilla.com wrote:

From: Trevor Saunders <tsaunders@mozilla.com>

Hi,

This patch adds a hash_map class so we can consolidate the boiler

plate around

using hash_table as a map, it also allows us to get rid of

pointer_map which I

do in this patch by converting its users to hash_map.

Hello Trev,
    I like your changes! One small question about pointer_set, which

is unable of deletion of items. Do you plan to migrate and simplify
hash_map to be a replacement for pointer_set?

Note that pointer-map use in LTO is quite performance critical. It

would be good to double

check that the new use of hash does not produce slower code.

I believe the compiled code should be very similar, but I'll do  some
measuring to check.

More important is memory use.

Richard.

Hi,
   there's memory usage graph for current trunk and before Trevor's patchset. It looks there's no memory footprint regression.

https://drive.google.com/file/d/0B0pisUJ80pO1OG5uY28yNFRnWTA/edit?usp=sharing

Martin

Trev

Honza

References:
- [PATCH 1/N] hash_table: Make a layer of indirection explicit
  - From: tsaunders
- [PATCH 3/3] add hash_map class
  - From: tsaunders
- Re: [PATCH 3/3] add hash_map class
  - From: Martin Liška
- Re: [PATCH 3/3] add hash_map class
  - From: Jan Hubicka
- Re: [PATCH 3/3] add hash_map class
  - From: Trevor Saunders
- Re: [PATCH 3/3] add hash_map class
  - From: Richard Biener

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]