This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [BUILDROBOT] frv fallout (was: Turn DECL_SECTION_NAME into string)
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Jan-Benedict Glaw <jbglaw at lug-owl dot de>
- Cc: Jan Hubicka <jh at suse dot cz>, Nick Clifton <nickc at redhat dot com>, Alexandre Oliva <aoliva at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 25 Jun 2014 07:23:20 +0200
- Subject: Re: [BUILDROBOT] frv fallout (was: Turn DECL_SECTION_NAME into string)
- Authentication-results: sourceware.org; auth=none
- References: <20140612043325 dot GA6864 at kam dot mff dot cuni dot cz> <20140625012257 dot GO31494 at lug-owl dot de>
> Hi!
>
> Fallout for frv, see eg. http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=272377
>
> g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I/home/jbglaw/repos/gcc/gcc -I/home/jbglaw/repos/gcc/gcc/. -I/home/jbglaw/repos/gcc/gcc/../include -I/home/jbglaw/repos/gcc/gcc/../libcpp/include -I/home/jbglaw/repos/gcc/gcc/../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libbacktrace -o frv.o -MT frv.o -MMD -MP -MF ./.deps/frv.TPo /home/jbglaw/repos/gcc/gcc/config/frv/frv.c
> /home/jbglaw/repos/gcc/gcc/config/frv/frv.c: In function ârtx_def* frv_expand_builtin(tree_node*, rtx_def*, rtx_def*, machine_mode, int)â:
> /home/jbglaw/repos/gcc/gcc/config/frv/frv.c:9420: warning: comparison between signed and unsigned integer expressions
> /home/jbglaw/repos/gcc/gcc/config/frv/frv.c:9424: warning: comparison between signed and unsigned integer expressions
> /home/jbglaw/repos/gcc/gcc/config/frv/frv.c:9428: warning: comparison between signed and unsigned integer expressions
> /home/jbglaw/repos/gcc/gcc/config/frv/frv.c:9432: warning: comparison between signed and unsigned integer expressions
> /home/jbglaw/repos/gcc/gcc/config/frv/frv.c:9436: warning: comparison between signed and unsigned integer expressions
> /home/jbglaw/repos/gcc/gcc/config/frv/frv.c:9440: warning: comparison between signed and unsigned integer expressions
> /home/jbglaw/repos/gcc/gcc/config/frv/frv.c:9444: warning: comparison between signed and unsigned integer expressions
> /home/jbglaw/repos/gcc/gcc/config/frv/frv.c:9448: warning: comparison between signed and unsigned integer expressions
> /home/jbglaw/repos/gcc/gcc/config/frv/frv.c:9453: warning: comparison between signed and unsigned integer expressions
> /home/jbglaw/repos/gcc/gcc/config/frv/frv.c:9458: warning: comparison between signed and unsigned integer expressions
> /home/jbglaw/repos/gcc/gcc/config/frv/frv.c:9462: warning: comparison between signed and unsigned integer expressions
> /home/jbglaw/repos/gcc/gcc/config/frv/frv.c:9467: warning: comparison between signed and unsigned integer expressions
> /home/jbglaw/repos/gcc/gcc/config/frv/frv.c: In function âbool frv_in_small_data_p(const tree_node*)â:
> /home/jbglaw/repos/gcc/gcc/config/frv/frv.c:9491: error: request for member âbaseâ in â* section_nameâ, which is of non-class type âconst charâ
> make[1]: *** [frv.o] Error 1
And this one is missed sanity check.
I will grep md files for apperances of DECL_SECTION_NAME, those I missed when updating the tree first time.
Index: gcc/config/frv/frv.c
===================================================================
--- gcc/config/frv/frv.c (revision 211693)
+++ gcc/config/frv/frv.c (working copy)
@@ -9488,7 +9488,6 @@
section_name = DECL_SECTION_NAME (decl);
if (section_name)
{
- gcc_assert (TREE_CODE (section_name) == STRING_CST);
if (frv_string_begins_with (section_name, ".sdata"))
return true;
if (frv_string_begins_with (section_name, ".sbss"))