This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [GOOGLE] Do not change edge probabilities when propagating edge counts
- From: Dehao Chen <dehao at google dot com>
- To: Yi Yang <ahyangyi at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 24 Jun 2014 15:14:05 -0700
- Subject: Re: [GOOGLE] Do not change edge probabilities when propagating edge counts
- Authentication-results: sourceware.org; auth=none
- References: <CADvRsea9GWbAympYeNp0zZMhVYeUawgvgCJJmWrtGkeS1+m9yA at mail dot gmail dot com>
OK for google-4_8 and google-4_9
Thanks,
Dehao
On Tue, Jun 24, 2014 at 3:09 PM, Yi Yang <ahyangyi@google.com> wrote:
> Hi,
>
> This patch removes unnecessary edge probability calculations in
> afdo_propagate_circuit() that would eventually be overridden by
> afdo_calculate_branch_prob().
>
> This would pave the way for my next patch, which compares the
> estimated branch probabilities or the branch annotations against the
> real profile data.
>
> Thanks,
> Yi
>
> gcc/
>
> 2014-06-24 Yi Yang <ahyangyi@google.com>
>
> * auto-profile.c (afdo_propagate_circuit): Do not change edge
> probabilities when propagating edge counts
>
> diff --git gcc/auto-profile.c gcc/auto-profile.c
> index 51e318d..74d3d1d 100644
> --- gcc/auto-profile.c
> +++ gcc/auto-profile.c
> @@ -1328,16 +1328,9 @@ afdo_propagate_circuit (void)
> continue;
> total++;
> only_one = ep;
> - if (e->probability == 0 && (e->flags & EDGE_ANNOTATED) == 0)
> - {
> - ep->probability = 0;
> - ep->count = 0;
> - ep->flags |= EDGE_ANNOTATED;
> - }
> }
> if (total == 1 && (only_one->flags & EDGE_ANNOTATED) == 0)
> {
> - only_one->probability = e->probability;
> only_one->count = e->count;
> only_one->flags |= EDGE_ANNOTATED;
> }
> --