This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [Committed] [PATCH] PR61123 : Fix the ABI mis-matching error caused by LTO



> -----Original Message-----
> From: Jakub Jelinek [mailto:jakub@redhat.com]
> Sent: 2014年6月21日 5:24
> To: Hale Wang
> Cc: 'Mike Stump'; Richard Biener; Mike Stump; GCC Patches
> Subject: Re: [Committed] [PATCH] PR61123 : Fix the ABI mis-matching error
> caused by LTO
> 
> On Fri, Jun 20, 2014 at 01:14:52PM +0800, Hale Wang wrote:
> > 2014-06-20 Hale Wang <hale.wang@arm.com>
> >
> >         * gcc.target/arm/lto/: New folder to verify the LTO option.
> >         * gcc.target/arm/lto/pr61123-enum-size_0.c: New test case.
> >         * gcc.target/arm/lto/pr61123-enum-size_1.c: Likewise.
> >         * gcc.target/arm/lto/lto.exp: New exp file used to test LTO
option.
> >         * lib/lto.exp (object-readelf): New procedure.
> 
> This FAILs on non-arm targets.
> 
> I've committed following fix as obvious.

Thank you very much.

> On the other side, if you don't plan to add too many arm LTO tests,
> supposedly putting it into gcc.dg/lto and just using arm*-*-* target
selector
> might be better.

We plan to add more cases to check LTO ABI issues, like short-wchar. All the
ABI would be ARM special. So all the test cases would be ARM special.

Thanks and Best Regards,
Hale Wang 
 
> 2014-06-20  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* gcc.target/arm/lto/lto.exp: Exit immediately if not arm*-*-*
target.
> 
> --- gcc/testsuite/gcc.target/arm/lto/lto.exp.jj	2014-06-20
> 08:02:50.000000000 +0200
> +++ gcc/testsuite/gcc.target/arm/lto/lto.exp	2014-06-20
> 23:19:33.850043692 +0200
> @@ -16,6 +16,10 @@
>  #
>  # Contributed by Diego Novillo <dnovillo@google.com>
> 
> +# Exit immediately if this isn't an ARM target.
> +if ![istarget arm*-*-*] then {
> +  return
> +}
> 
>  # Test link-time optimization across multiple files.
>  #
> 
> 
> 	Jakub




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]