This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix up -march=native handling under KVM (PR target/61570)


On Sat, Jun 21, 2014 at 8:07 PM, Jakub Jelinek <jakub@redhat.com> wrote:

>> > --- gcc/config/i386/driver-i386.c.jj    2014-05-14 14:45:54.000000000 +0200
>> > +++ gcc/config/i386/driver-i386.c       2014-06-20 18:59:57.805006358 +0200
>> > @@ -745,6 +745,11 @@ const char *host_detect_local_cpu (int a
>> >                     /* Assume Core 2.  */
>> >                     cpu = "core2";
>> >                 }
>> > +             else if (has_longmode)
>> > +               /* Perhaps some emulator?  Assume x86-64, otherwise gcc
>> > +                  -march=native would be unusable for 64-bit compilations,
>> > +                  as all the CPUs below are 32-bit only.  */
>> > +               cpu = "x86-64";
>> >               else if (has_sse3)
>> >                 /* It is Core Duo.  */
>> >                 cpu = "pentium-m";
>> >
>> >         Jakub
>>
>> host_detect_local_cpu guesses the cpu based on the real processors.
>> It doesn't work with emulators due to some conflicts.  This isn't the
>> only only place which has the same issue.   I prefer something like
>> this.
>
> I'm fine with your patch too.  Let's wait what Uros (or other i?86
> maintainers) pick up.

This looks OK to me.

Thanks,
Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]