This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, ARM] MI-thunk fix for TARGET_THUMB1_ONLY


On 2014/6/18 äå 06:26, Ramana Radhakrishnan wrote:
> On Sun, Jun 8, 2014 at 12:27 PM, Chung-Lin Tang <cltang@codesourcery.com> wrote:
>> > Hi Richard, Ramana,
>> >
>> > Attached is a small fix for resolving a g++.old-deja/g++.jason/thunk2.C
>> > regression we found under a TARGET_THUMB1_ONLY multilib (-mthumb
>> > -march=armv6-m to be exact). Basically under those conditions, the thunk
>> > is in Thumb mode, so the subtraction should be 4 rather than 8.
> Yep, this is OK with a minor change to the comment to make it more explicit.
> 
>> >+      /* Output ".word .LTHUNKn-[37]-.LTHUNKPCn".  */
> s/37/3,7/
> 
> 
> Ok with that change and if no regressions.
> 
> OK for release branches unless the RM's object in 24 hours.

Re-tested on a recent trunk, verified g++.jason/thunk2.C resolved with
patch and no regressions. Committed on trunk and backported to 4.8, 4.9
branches.

Thanks,
Chung-Lin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]