This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR61123 : Fix the ABI mis-matching error caused by LTO
- From: Mike Stump <mikestump at comcast dot net>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: Hale Wang <Hale dot Wang at arm dot com>, Mike Stump <mrs at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 18 Jun 2014 10:41:52 -0700
- Subject: Re: [PATCH] PR61123 : Fix the ABI mis-matching error caused by LTO
- Authentication-results: sourceware.org; auth=none
- References: <001801cf8acd$512b1360$f3813a20$ at arm dot com> <CAFiYyc3KYx1p2AyY2CkBbR92qjuzE4pACaqiq-BdbgHo0OVUvQ at mail dot gmail dot com> <CAFiYyc3orW=wP1s=2dSv9uH3PCYxkJUToTOcO_OAcSsPsSN0FQ at mail dot gmail dot com>
On Jun 18, 2014, at 3:22 AM, Richard Biener <richard.guenther@gmail.com> wrote:
>> Space after the *.
>>
>> I think you don't need to copy the LTO harness but you can simply
>> use dg.exp and sth similar to gcc.dg/20081223-1.c (there is an
>> effective target 'lto' to guard for lto support).
>>
>> So simply place the testcase in gcc.target/arm/ (make sure to
>> put a dg-do compile on the 2nd file and use dg-additional-sources).
>>
>> If that doesn't work I'd say put the testcase in gcc.dg/lto/ instead
>> and do a dg-skip-if for non-arm targets.
>>
>> Ok with one of those changes.
>
> Oh, I see you need a new object-readelf ... I defer to a testsuite maintainer
> for this part.
The testsuite bits are Ok. My guidance on the test suite would be this, all lto test cases in .*lto directories. 20 or fewer test cases for a given target, in the main lto directory, more than 50, in the arm/lto directory. When one is tracking down bugs and trying to clean test suite results if they break, it is nice to be able to skip in mass all lto bugs first, and resolve all non-lto issues and then come back to the lto issues last, in hopes that they are all then resolved. Also, if one it redoing lto bits, and a test case with lto in the name pops up as a regression, and you’re not an lto person, you can stop thinking about it and just pass to the lto person, it is a slightly different mindset. :-)