This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, ARM] MI-thunk fix for TARGET_THUMB1_ONLY


On Sun, Jun 8, 2014 at 12:27 PM, Chung-Lin Tang <cltang@codesourcery.com> wrote:
> Hi Richard, Ramana,
>
> Attached is a small fix for resolving a g++.old-deja/g++.jason/thunk2.C
> regression we found under a TARGET_THUMB1_ONLY multilib (-mthumb
> -march=armv6-m to be exact). Basically under those conditions, the thunk
> is in Thumb mode, so the subtraction should be 4 rather than 8.

Yep, this is OK with a minor change to the comment to make it more explicit.

>+      /* Output ".word .LTHUNKn-[37]-.LTHUNKPCn".  */

s/37/3,7/


Ok with that change and if no regressions.

OK for release branches unless the RM's object in 24 hours.

It would be nice to see if we could rewrite the mi thunk code like
other backends but that's the matter of a separate patch.

Ramana
>
> Original patch was by Julian, with trivial adaptations for trunk by me.
> We've been carrying this fix for a while by now. Okay for trunk? (and
> stable branches?)
>
> Thanks,
> Chung-Lin
>
> 2014-06-08  Julian Brown  <julian@codesourcery.com>
>             Chung-Lin Tang  <cltang@codesourcery.com>
>
>         * config/arm/arm.c (arm_output_mi_thunk): Fix offset for
>         TARGET_THUMB1_ONLY. Add comments.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]