Re: [patch libatomic]: Add basic support for mingw targets

[Jeff Law <law at redhat dot com>]

On 06/17/14 13:31, Kai Tietz wrote:
> 2014-06-17 21:16 GMT+02:00 Jeff Law <law@redhat.com>:
> > On 06/16/14 07:20, Kai Tietz wrote:
> > > Hello,
> > >
> > > this patch adds basic support for libatomic for mingw targets using
> > > win32 and for mingw targets using posix threading model.
> > >
> > > The win32 implemenation might need for initialization of mutexes a
> > > critical section.  If issue occures we can still add that.  For now
> > > all testcases are passing for native and posix-threading model mingw
> > > (32-bit and 64-bit).
> > >
> > > ChangeLog
> > >
> > > 2014-06-16  Kai Tietz  <ktietz@redhat.com>
> > >
> > >       * Makefile.am (libatomic_la_LDFLAGS): Add lt_host_flags.
> >
> > Isn't this all target stuff, in which case lt_host_flags seems
> > inappropriate.  Or is this just poorly named?
>
> Hmm, libatomic is here build for new host (means it is a gcc-target
> library).  So it might be named poorly.  Nevertheless see for details
> ACX_LT_HOST_FLAGS in config/lthostflags.m4 and why it is required to
> set -no-undefined and the proper bindir for cygwin/mingw.
Right, I'm aware that libatomic is a target library.  What I'm worried 
about is confusion due to using ACX_LT_HOST_FLAGS and possible pollution 
of flags originally the host being used for the target library build.

Given that several other libraries use similar constraints to get 
lt_host_flags into LDFLAGS, I guess pollution isn't (or better stated 
hasn't) been an issue.

Approved.

Jeff