This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Go patch committed: Pass -t to native linker on Solaris


On Mon, Jun 16, 2014 at 6:58 AM, Ian Lance Taylor <iant@google.com> wrote:
> On Mon, Jun 16, 2014 at 3:56 AM, Rainer Orth
> <ro@cebitec.uni-bielefeld.de> wrote:
>>
>> Works fine, thanks.  Just before your patch arrived, I meant to test the
>> following, slightly more general patch.  Perhaps it's an option to
>> handle other quirks like this?
>
> This approach is fine with me, but the target macro should be
> documented somwhere.  We need to document that multiple options have
> to be separated with commas, not spaces.

Also I think it would be better to write it along the lines of the
following, to allow runtime determination of whether the option is
needed.


#ifdef TARGET_GO_LINK_OPTIONS
  /* Pass target specific linker options if present.  */
  {
    const char *p = TARGET_GO_LINK_OPTIONS;
    if (p != NULL && *p != '\0')
      generate_option (OPT_Wl_, TARGET_GO_LINK_OPTIONS, 1, CL_DRIVER,
		       &new_decoded_options[j++]);
  }
#endif


Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]