This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING][PATCH, trunk, 4.9, 4.8] Fix PR57653, filename information discarded when using -imacros
- From: Peter Bergner <bergner at vnet dot ibm dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Manuel López-Ibáñez <manu at gcc dot gnu dot org>, Allan McRae <allan at archlinux dot org>
- Date: Wed, 11 Jun 2014 18:23:49 -0500
- Subject: Re: [PING][PATCH, trunk, 4.9, 4.8] Fix PR57653, filename information discarded when using -imacros
- Authentication-results: sourceware.org; auth=none
- References: <1402521323 dot 20018 dot 8 dot camel at otta> <Pine dot LNX dot 4 dot 64 dot 1406112305390 dot 25187 at digraph dot polyomino dot org dot uk>
On Wed, 2014-06-11 at 23:07 +0000, Joseph S. Myers wrote:
> On Wed, 11 Jun 2014, Peter Bergner wrote:
>
> > I'd like to ping the following patch that fixes PR57653. This did
> > bootstrap and regtest with no regressions on powerpc64-linux.
> >
> > https://gcc.gnu.org/ml/gcc-patches/2014-04/msg01571.html
> >
> > Is this ok for trunk, 4.9 and 4.8?
>
> I think the code change is correct, but the comment added needs expanding
> to explain better what's going on (i.e. the circumstances in which the
> condition include_cursor > deferred_count may hold, and why, in those
> circumstances, returning early is the correct thing to do).
Manuel, can you offer an updated comment? Being just the patch
tester and not knowing this code at all, I'm not going to be of
much use at expanding the Manuel's original comment.
Peter