This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

From: Kugan <kugan dot vivekanandarajah at linaro dot org>
To: ramrad01 at arm dot com
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>
Date: Tue, 10 Jun 2014 09:25:22 +1000
Subject: Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook
Authentication-results: sourceware.org; auth=none
References: <535B89D6 dot 2070309 at linaro dot org> <Pine dot LNX dot 4 dot 64 dot 1405020012530 dot 16441 at digraph dot polyomino dot org dot uk> <53635FBA dot 7060505 at linaro dot org> <53700C12 dot 4000102 at linaro dot org> <5382F4C4 dot 9000508 at linaro dot org> <CAJA7tRayghjpkdKDpzoz6doTQ162N9dwq8w6rkicoXNAHZQrTQ at mail dot gmail dot com>

On 30/05/14 18:35, Ramana Radhakrishnan wrote:
>> +  if (!TARGET_VFP)
>> +    return;
>> +
>> +  /* Generate the equivalence of :
> 
> s/equivalence/equivalent.
> 
> Ok with that change and if no regressions.

Hi Ramana,

Sorry, I missed the thumb1 part. There are no mrc/mcr  versions of these
instructions in thumb1. So these should be conditional on not being
ARM_THUMB1.

Is this OK. Regression tested with no new refression on qemu for
arm-none-linux-gnueabi -march=armv7-a and on arm-none-linux-gnueabi
--with-mode=thumb and -march=armv5t.

Is this OK?

Thanks,
Kugan

gcc/

2014-06-10  Kugan Vivekanandarajah  <kuganv@linaro.org>

	* config/arm/arm.c (arm_atomic_assign_expand_fenv): call
	default_atomic_assign_expand_fenv for TARGET_THUMB1.
	(arm_init_builtins) : Initialize builtins __builtins_arm_set_fpscr and
	__builtins_arm_get_fpscr only when !TARGET_THUMB1.
	* config/arm/vfp.md (set_fpscr): Make pattern conditional on
	!TARGERT_THUMB1.
	(get_fpscr) : Likewise.

Attachment: p.txt
Description: Text document

Follow-Ups:
- Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook
  - From: Ramana Radhakrishnan

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]