This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Support asan-instrumentation-with-call-threshold in GCC (second try)
- From: Yury Gribov <y dot gribov at samsung dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Konstantin Serebryany <kcc at gcc dot gnu dot org>, Viacheslav Garbuzov <v dot garbuzov at samsung dot com>, Dmitry Vyukov <dvyukov at google dot com>
- Date: Mon, 09 Jun 2014 08:53:48 +0400
- Subject: Re: [PATCH] Support asan-instrumentation-with-call-threshold in GCC (second try)
- Authentication-results: sourceware.org; auth=none
- References: <538D8136 dot 3030402 at samsung dot com> <20140603083751 dot GU10386 at tucnak dot redhat dot com> <53914CC1 dot 30104 at samsung dot com> <20140606060153 dot GK10386 at tucnak dot redhat dot com>
> 1) instrument_mem_region_access/instrument_strlen should use a single
> build_check_stmt call instead of two that they do now,
I agree with instrument_mem_region_access but the strlen case is quite
different because checks are inserted at different sides of instrumented
insn. Adding yet more flags and code paths to build_check_stmt would
IMHO overcomplicate it.
-Y