This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RS6000] PR61300 K&R incoming args
- From: Alan Modra <amodra at gmail dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, dje dot gcc at gmail dot com, rguenth at gcc dot gnu dot org, Aldy Hernandez <aldyh at redhat dot com>
- Date: Fri, 6 Jun 2014 10:36:08 +0930
- Subject: Re: [RS6000] PR61300 K&R incoming args
- Authentication-results: sourceware.org; auth=none
- References: <20140529065504 dot GL6679 at bubble dot grove dot modra dot org> <5390D88F dot 2000208 at redhat dot com>
On Thu, Jun 05, 2014 at 02:52:31PM -0600, Jeff Law wrote:
> >+@defmac INCOMING_REG_PARM_STACK_SPACE (@var{fndecl})
> >+Like @code{REG_PARM_STACK_SPACE}, but for incoming register arguments.
> >+Define this macro if space guaranteed when compiling a function body
> >+is different to space required when making a call, a situation that
> >+can arise with unprototyped functions.
> >+@end defmac
> Might be better to clarify ever-so-slightly with "unprototyped
> function definitions" or "K&R style function defintions". Similarly
> for the comment for the definition in rs6000.h
OK, I went with "K&R style function definitions".
> There's a few other references to REG_PARM_STACK_SPACE in comments,
> can you review those and change to INCOMING_REG_PARM_STACK_SPACE if
> necessary.
I looked at all of them again and decided they should stay as is. The
comment above locate_and_pad_parm must, because it is describing the
reg_parm_stack_space parameter, not the macro. The comment in
assign_parm_find_entry_rtl is really about all->reg_parm_stack_space
so it too should remain unchanged. That leaves just the comment near
the start of the file, and since it says "If REG_PARM_STACK_SPACE is
defined" that is still true and reads best for someone coming from a
target that doesn't define INCOMING_REG_PARM_STACK_SPACE.
> OK to apply.
Thanks for reviewing! Committed revision 211296.
--
Alan Modra
Australia Development Lab, IBM