This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, Pointer Bounds Checker 19/x] Support bounds in expand
- From: Michael Matz <matz at suse dot de>
- To: Ilya Enkovich <enkovich dot gnu at gmail dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 4 Jun 2014 16:36:31 +0200 (CEST)
- Subject: Re: [PATCH, Pointer Bounds Checker 19/x] Support bounds in expand
- Authentication-results: sourceware.org; auth=none
- References: <20140602150245 dot GB53659 at msticlxl57 dot ims dot intel dot com> <alpine dot LNX dot 2 dot 00 dot 1406021721540 dot 25307 at wotan dot suse dot de> <CAMbmDYZwAMOBiRFeiecYV_gkBpozfs1j+e9kTnPqko7d+GWY9w at mail dot gmail dot com>
Hi,
On Mon, 2 Jun 2014, Ilya Enkovich wrote:
> > There is exactly one place (except for the self-recursive ones) where
> > you call the new store_expr with a non-null argument for bounds
> > target, and it seems to be only necessary for when some sub-expression
> > of the RHS is a call. Can you somehow arrange to move that handling
> > to the single place in expand_assignment() so that you don't need to
> > change the signature of store_expr?
>
> I see the only nice way to do it - store_expr should return bounds of
> expanded exp. Currently it always return NULL_RTX. Does it look better
> than a new argument?
IMHO it does. That or introducing a new store_expr_with_bounds (with the
new argument) and letting store_expr be a wrapper for that, passing the
NULL. Basically anything that avoids adding a new parameter for most of
the existing calls to store_expr.
Ciao,
Michael.