This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 3/5] Make recog_op_alt consumers check the enabled attribute
- From: Jeff Law <law at redhat dot com>
- To: gcc-patches at gcc dot gnu dot org, rdsandiford at googlemail dot com
- Date: Tue, 03 Jun 2014 15:58:53 -0600
- Subject: Re: [PATCH 3/5] Make recog_op_alt consumers check the enabled attribute
- Authentication-results: sourceware.org; auth=none
- References: <87egzokglh dot fsf at talisman dot default> <537B9911 dot 7070604 at redhat dot com> <87mwdyfhhg dot fsf_-_ at talisman dot default> <87a99yfgx3 dot fsf_-_ at talisman dot default>
On 05/31/14 03:15, Richard Sandiford wrote:
As described in the covering note, it seems better to put the onus of
checking the enabled attribute on the passes that are walking each
alternative, like LRA does for its internal subpasses. That leads
to a nicer interface in patch 4 and would make it easier to precompute
the information at build time. (The only thing preventing that now is
the subunion class.)
Thanks,
Richard
gcc/
* recog.c (preprocess_constraints): Don't skip disabled alternatives.
* ira-lives.c (check_and_make_def_conflict): Check for disabled
alternatives.
(make_early_clobber_and_input_conflicts): Likewise.
* config/i386/i386.c (ix86_legitimate_combined_insn): Likewise.
Did you spot check the other ports which utilized the enabled attribute
to see if they need tweaking too?
I see aarch64, alpha, arc, arm, avr, c6x m68k, mips, mn10300, nds32,
s390, sh & sparc. I didn't check to see if any of them walk the
alternatives in the backend.
Assuming you at least spot checked them, then this patch is OK.
jeff