This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [GOOGLE] Emit linkage_name when built with -gmlt and for abstract decls


This will increase c++ g1/g2 binary size a little. For all spec
cint2006 benchmarks, the binary size change is shown below.

400 0.00% 0.00% 0.00% 0.00%
401 0.00% 0.00% 0.00% 0.00%
403 0.00% 0.00% 0.00% 0.00%
429 0.00% 0.00% 0.00% 0.00%
445 0.00% 0.00% 0.00% 0.00%
456 0.00% 0.00% 0.00% 0.00%
458 0.00% 0.00% 0.00% 0.00%
462 0.00% 0.00% 0.00% 0.00%
464 0.00% 0.00% 0.00% 0.00%
471 1.28% 0.20% 1.23% 0.15%
473 0.36% 0.00% 0.35% 0.01%
483 12.79% 1.73% 13.65% 2.12%
geomean 1.14% 0.16% 1.20% 0.19%

The 4 columns are:

o0 -g1
o0 -g2
o2 -g1
o2 -g2

Thanks,
Dehao

On Fri, May 30, 2014 at 3:23 PM, Dehao Chen <dehao@google.com> wrote:
> As we are pushing AutoFDO patch upstream, is this patch OK for trunk?
>
> Thanks,
> Dehao
>
> On Mon, Aug 19, 2013 at 1:32 PM, Dehao Chen <dehao@google.com> wrote:
>> After rerunning test, this will fail one gcc regression test. So I
>> updated the patch to make sure all test will pass:
>>
>> Index: gcc/dwarf2out.c
>> ===================================================================
>> --- gcc/dwarf2out.c (revision 201850)
>> +++ gcc/dwarf2out.c (working copy)
>> @@ -16545,10 +16545,9 @@ add_src_coords_attributes (dw_die_ref die, tree de
>>  static void
>>  add_linkage_name (dw_die_ref die, tree decl)
>>  {
>> -  if (debug_info_level > DINFO_LEVEL_TERSE
>> +  if (debug_info_level > DINFO_LEVEL_NONE
>>        && (TREE_CODE (decl) == FUNCTION_DECL || TREE_CODE (decl) == VAR_DECL)
>>        && TREE_PUBLIC (decl)
>> -      && !DECL_ABSTRACT (decl)
>>        && !(TREE_CODE (decl) == VAR_DECL && DECL_REGISTER (decl))
>>        && die->die_tag != DW_TAG_member)
>>      {
>> Index: gcc/testsuite/g++.dg/debug/dwarf2/cdtor-1.C
>> ===================================================================
>> --- gcc/testsuite/g++.dg/debug/dwarf2/cdtor-1.C (revision 201850)
>> +++ gcc/testsuite/g++.dg/debug/dwarf2/cdtor-1.C (working copy)
>> @@ -14,4 +14,4 @@ main()
>>    K k;
>>  }
>>
>> -// { dg-final {scan-assembler-times " DW_AT_\[MIPS_\]*linkage_name" 2 } }
>> +// { dg-final {scan-assembler-times " DW_AT_\[MIPS_\]*linkage_name" 4 } }
>>
>> On Mon, Aug 19, 2013 at 9:22 AM, Cary Coutant <ccoutant@google.com> wrote:
>>>> This patch emits linkage_name at -gmlt. It also make sure abstract
>>>> decls' linkage_names are emitted so that inlined functions can also
>>>> find linkage name.
>>>>
>>>> Bootstrapped and passed regression test.
>>>>
>>>> OK for google branches?
>>>
>>> OK.
>>>
>>> -cary


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]