This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [build, doc, testsuite] Centralise clearing hardware capabilities with Sun ld


Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:

> Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
>
>> Prompted by the recent failures of c-c++-common/gomp/pr60823-2.c on
>> Solaris/x86 with Sun as
>>
>> 	http://gcc.gnu.org/ml/gcc-patches/2014-05/msg00943.html
>>
>> I've reworked the clearing of hardware capabilities via linker maps for
>> Sun ld, which is currently replicated in several places all over the
>> testsuite.  I've chosen to use TEST_ALWAYS_FLAGS or ALWAYS_CXXFLAGS to
>> pass on the necessary linker flags.
>
> It turned out that more is needed to deal with the new gcc.dg/gomp and
> g++.dg/gomp failures:
>
> 	https://gcc.gnu.org/ml/gcc-patches/2014-05/msg01185.html
>
> The following patch implements what I've outlined there: it introduces a
> Solaris-specific new -mclear-hwcap option, checking which version of
> the mapfile syntax works, if any.  This way, all the duplication in the
> testsuite and libitm can go.
>
> Do deal with the OpenMP declare simd failures, this option/mapfile is
> automatically activated with -fopenmp*.
>
> Initial testing has concluded successfully, also on an Solaris 10/x86
> system where ld only understands the old mapfile syntax.  Mainline
> bootstraps on i386-pc-solaris2.11 (as/ld, gas/ld, gas/gld),
> i386-pc-solaris2.10 (as/ld, gas/ld), and sparc-sun-solaris2.11 (as/ld)
> are still running.  x86_64-unknown-linux-gnu didn't finish due to
> unrelated libgo breakage.  Also, i386-pc-solaris2.9 bootstrap running on
> the 4.9 branch which is equally affected by the testsuite failures.
>
> Ok for mainline and 4.9 branch if those pass?

It's been a week since I've submitted the patch, so far having received
approval for the testsuite parts only.

While I don't need approval for the Solaris-only parts, it would be good
if the doc and build changes could be checked by the respective
maintainers.  One might argue that they are Solaris-only, thus falling
under my maintainership, but better safe than sorry.

Thanks.
        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]