This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: libsanitizer merge from upstream r208536

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Yury Gribov <y dot gribov at samsung dot com>, Jakub Jelinek <jakub at redhat dot com>
Cc: Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>, Andrew Pinski <pinskia at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Dodji Seketeli <dodji at redhat dot com>, Dmitry Vyukov <dvyukov at google dot com>, Marek Polacek <polacek at redhat dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, Yuri Gribov <tetra2005 at gmail dot com>
Date: Fri, 23 May 2014 12:52:36 +0200
Subject: Re: libsanitizer merge from upstream r208536
Authentication-results: sourceware.org; auth=none
References: <CAGQ9bdzNff1SK-BT9vYBdeX1mFeMKw0eTvaLb63qd8e4ow88NA at mail dot gmail dot com> <b75522cf-9cc0-4e53-a497-f939a512259a at email dot android dot com> <20140522094737 dot GZ10386 at tucnak dot redhat dot com> <CAGQ9bdy+j4+-immgKGdUHwc6au_jRzxCnuy=ehKZozbq6Ks2Qw at mail dot gmail dot com> <20140522110348 dot GC10386 at tucnak dot redhat dot com> <537E4427 dot 4060006 at oracle dot com> <20140522190200 dot GJ10386 at tucnak dot redhat dot com> <537E4A10 dot 8090205 at oracle dot com> <20140522191528 dot GK10386 at tucnak dot redhat dot com> <537E5345 dot 2030804 at oracle dot com> <20140522195437 dot GN10386 at tucnak dot redhat dot com> <537EDCE4 dot 6070509 at samsung dot com> <537F0BBB dot 9020505 at samsung dot com> <537F0DD7 dot 7040501 at oracle dot com> <537F131A dot 5020305 at samsung dot com> <537F13EE dot 3010600 at oracle dot com> <537F224A dot 9070107 at samsung dot com>

Hi,

On 05/23/2014 12:26 PM, Yury Gribov wrote:

>> Could you add something like
>
> It's always linux-vdso.so.1, but wasn't that already known, given the
> ldd requested by Jakub?!?
Well, for me dlpi_name for vdso was empty string hence I kept asking.I also thought that ldd and dl_iterate_phdr might have used slightlydifferent code paths when quering information from dynamic linker.
Could you check if the attached patch fixes the problem for you?
Note that I only did limited testing (RUNTESTFLAGS=asan.exp).

Thanks. It appears to work great for me modulo a trivial off-by-one (youwant sizeof(...) - 1) and the asan_test.C issue already discussed by Jakub.


Paolo.

References:
- Re: libsanitizer merge from upstream r208536
  - From: Konstantin Serebryany
- Re: libsanitizer merge from upstream r208536
  - From: Paolo Carlini
- Re: libsanitizer merge from upstream r208536
  - From: Jakub Jelinek
- Re: libsanitizer merge from upstream r208536
  - From: Konstantin Serebryany
- Re: libsanitizer merge from upstream r208536
  - From: Jakub Jelinek
- Re: libsanitizer merge from upstream r208536
  - From: Paolo Carlini
- Re: libsanitizer merge from upstream r208536
  - From: Jakub Jelinek
- Re: libsanitizer merge from upstream r208536
  - From: Paolo Carlini
- Re: libsanitizer merge from upstream r208536
  - From: Jakub Jelinek
- Re: libsanitizer merge from upstream r208536
  - From: Paolo Carlini
- Re: libsanitizer merge from upstream r208536
  - From: Jakub Jelinek
- Re: libsanitizer merge from upstream r208536
  - From: Yury Gribov
- Re: libsanitizer merge from upstream r208536
  - From: Yury Gribov
- Re: libsanitizer merge from upstream r208536
  - From: Paolo Carlini
- Re: libsanitizer merge from upstream r208536
  - From: Yury Gribov
- Re: libsanitizer merge from upstream r208536
  - From: Paolo Carlini
- Re: libsanitizer merge from upstream r208536
  - From: Yury Gribov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]