This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] proposed fix for bug # 61144
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Rich Felker <dalias at libc dot org>, Jan Hubicka <hubicka at ucw dot cz>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 21 May 2014 11:17:53 +0200
- Subject: Re: [PATCH] proposed fix for bug # 61144
- Authentication-results: sourceware.org; auth=none
- References: <20140521015948 dot GA21600 at brightrain dot aerifal dot cx>
On Wed, May 21, 2014 at 3:59 AM, Rich Felker <dalias@libc.org> wrote:
> Bug # 61144 is a regression in 4.9.0 that breaks building of musl libc
> due to aggressive and semantically-incorrect constant folding of weak
> aliases. The attached patch seems to fix the issue. A weak alias
> should never be a candidate for constant folding because it may always
> be replaced by a strong definition from another translation unit.
>
> For details see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61144
>
> I do not have a copyright assignment on file but this patch should be
> sufficiently trivial not to require it.
Please add a testcase. Also I wonder why it isn't better to generalize
/* Variables declared 'const' without an initializer
have zero as the initializer if they may not be
overridden at link or run time. */
if (!DECL_INITIAL (real_decl)
&& (DECL_EXTERNAL (decl) || decl_replaceable_p (decl)))
return error_mark_node;
Honza?
Thanks,
Richard.
> Rich