This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix ARM NAN fraction bits
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Ian Lance Taylor <ian at airs dot com>
- Cc: Richard Biener <rguenther at suse dot de>, <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 20 May 2014 01:28:12 +0100
- Subject: Re: [PATCH] Fix ARM NAN fraction bits
- Authentication-results: sourceware.org; auth=none
- References: <000b01cf3367$439c5280$cad4f780$ at arm dot com> <alpine dot DEB dot 1 dot 10 dot 1405160245300 dot 12061 at tp dot orcam dot me dot uk> <Pine dot LNX dot 4 dot 64 dot 1405161702480 dot 18605 at digraph dot polyomino dot org dot uk> <alpine dot DEB dot 1 dot 10 dot 1405162313110 dot 12061 at tp dot orcam dot me dot uk> <1024398b-c40a-45a9-9bde-03d39d24867b at email dot android dot com>
Ian,
On Sat, 17 May 2014, Richard Biener wrote:
> On May 17, 2014 12:22:23 AM CEST, "Maciej W. Rozycki" <macro@codesourcery.com> wrote:
> >On Fri, 16 May 2014, Joseph S. Myers wrote:
> >
> >> > 2014-05-16 Maciej W. Rozycki <macro@codesourcery.com>
> >> >
> >> > PR libgcc/60166
> >> > * sysdeps/arm/soft-fp/sfp-machine.h (_FP_NANFRAC_S, _FP_NANFRAC_D)
> >> > (_FP_NANSIGN_Q): Set the quiet bit.
> >>
> >> OK for glibc.
> >
> > Joseph, thanks for your review, this is now in.
> >
> >Richard, you wrote yesterday that pushing changes to 4.8 would require
> >explicit approval from release managers, however it is not clear to me
> >who
> >they are for that branch. This fix corrects a regression introduced
> >after
> >4.8.2. Can you approve it? If not, then who can?
>
> If it's not broken in 4.8.2 but broken on the branch head then it's OK
> for the branch.
I thought I'd double-check with you that it is fine to push this change
to trunk first. OK to apply?
2014-05-20 Maciej W. Rozycki <macro@codesourcery.com>
PR libgcc/60166
libgcc/
* config/arm/sfp-machine.h (_FP_NANFRAC_S, _FP_NANFRAC_D)
(_FP_NANSIGN_Q): Set the quiet bit.
Maciej
gcc-soft-fp-arm-nanfrac.diff
Index: gcc-fsf-trunk-quilt/libgcc/config/arm/sfp-machine.h
===================================================================
--- gcc-fsf-trunk-quilt.orig/libgcc/config/arm/sfp-machine.h 2014-05-16 15:59:06.000000000 +0100
+++ gcc-fsf-trunk-quilt/libgcc/config/arm/sfp-machine.h 2014-05-20 01:23:36.618434199 +0100
@@ -21,10 +21,10 @@ typedef int __gcc_CMPtype __attribute__
/* According to RTABI, QNAN is only with the most significant bit of the
significand set, and all other significand bits zero. */
-#define _FP_NANFRAC_H 0
-#define _FP_NANFRAC_S 0
-#define _FP_NANFRAC_D 0, 0
-#define _FP_NANFRAC_Q 0, 0, 0, 0
+#define _FP_NANFRAC_H _FP_QNANBIT_H
+#define _FP_NANFRAC_S _FP_QNANBIT_S
+#define _FP_NANFRAC_D _FP_QNANBIT_D, 0
+#define _FP_NANFRAC_Q _FP_QNANBIT_Q, 0, 0, 0
#define _FP_NANSIGN_H 0
#define _FP_NANSIGN_S 0
#define _FP_NANSIGN_D 0